Skip to content

Add whitelist feature#77

Merged
PuneetGopinath merged 10 commits intomainfrom
add-whitelist-feature
Jul 2, 2021
Merged

Add whitelist feature#77
PuneetGopinath merged 10 commits intomainfrom
add-whitelist-feature

Conversation

@abhijoshi2k
Copy link
Member

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Added event whitelisting. Using whitelisted_events as parameter in config files will allow only those events to be included in recent-activity.

Note:

whitelisted_events will have priority over disabled_events

Closes #76

@abhijoshi2k abhijoshi2k added Type: enhancement New feature or request minor Will be added to next minor release Status: In progress This pr or issue is in progress Priority: low Low priority for this issue/pr. labels Jul 2, 2021
@abhijoshi2k
Copy link
Member Author

abhijoshi2k commented Jul 2, 2021

Seriously, I didn't thought you will work now itself on this.

It was very small change. Didn't take much time.

@abhijoshi2k
Copy link
Member Author

@PuneetGopinath Can you check if it's working as expected? Then I'll mention Andreas to update documentation and/or changelog.

@PuneetGopinath
Copy link
Member

PuneetGopinath commented Jul 2, 2021

@PuneetGopinath
Copy link
Member

@abhijoshi2k

@abhijoshi2k
Copy link
Member Author

An error occurred: https://github.com/PuneetGopinath/activity-test/runs/2970299783?check_suite_focus=true

Our workflow does not support triggering on push event. It requires cron schedule or workflow_dispatch trigger. Please remove push trigger.

@PuneetGopinath
Copy link
Member

An error occurred: https://github.com/PuneetGopinath/activity-test/runs/2970299783?check_suite_focus=true

Our workflow does not support triggering on push event. It requires cron schedule or workflow_dispatch trigger. Please remove push trigger.

I know that, am not a fool. I mean that when even I didn't add any push event it says that it is not supported

@PuneetGopinath
Copy link
Member

Check the config file for yourself

@abhijoshi2k
Copy link
Member Author

Check the config file for yourself

Dude you have a push trigger in workflow file. You need to remove it!

@PuneetGopinath
Copy link
Member

PuneetGopinath commented Jul 2, 2021

Check the config file for yourself

Dude you have a push trigger in workflow file. You need to remove it!

Hmm, okay
But didn't thought that push event would make a problem, as the same push event is in recent-activity

@abhijoshi2k
Copy link
Member Author

@PuneetGopinath
Copy link
Member

@abhijoshi2k
Copy link
Member Author

@Andre601 Can you update the readme and changelog?

@PuneetGopinath
Copy link
Member

Also add the note: whitelisted_events will have priority over disabled_events

@Andre601
Copy link
Member

Andre601 commented Jul 2, 2021

@Andre601 Can you update the readme and changelog?

I will once this PR is merged

@abhijoshi2k
Copy link
Member Author

@Andre601 Can you update the readme and changelog?

I will once this PR is merged

Okay. I'll add Status: Ready label. @PuneetGopinath you can review and merge.

@abhijoshi2k abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels Jul 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

The Pull request of @abhijoshi2k has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.


This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

Puneet Gopinath and others added 2 commits July 2, 2021 16:33
@PuneetGopinath PuneetGopinath merged commit 14ee0dd into main Jul 2, 2021
@PuneetGopinath PuneetGopinath deleted the add-whitelist-feature branch July 2, 2021 11:04
@PuneetGopinath
Copy link
Member

@Andre601 You can update docs (or wiki)
Also add the note: whitelisted_events will have priority over disabled_events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: I would like a whitelist option which is just opposite to the disabled_events option

3 participants