Merged
Conversation
PuneetGopinath
requested changes
May 8, 2021
Member
|
Thanks for the pr. The pr looks good, I can see this is a draft. See the changes I have requested, please resolve them. |
PuneetGopinath
approved these changes
May 8, 2021
abhijoshi2k
approved these changes
May 8, 2021
Member
abhijoshi2k
left a comment
There was a problem hiding this comment.
README looks much better now. Thanks for your efforts @Andre601
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the Readme with some better info and examples.
This is currently still a draft since there might be new options available in the near future. (See recent discussion)
Something I wasn't really sure about is if the info about Private repo activities being shown with a custom PAT is true.
If it is true, let me know.
Something else I considered but see an issue with right now is to make an Example Repository in this Organisation you have, that would use this action here. The issue I see is, that Organisations don't have activities, right? In such a case would it need a way to target a specific user for the activities.