Skip to content

Use src folder#59

Merged
PuneetGopinath merged 24 commits intomainfrom
src-folder
May 24, 2021
Merged

Use src folder#59
PuneetGopinath merged 24 commits intomainfrom
src-folder

Conversation

@PuneetGopinath
Copy link
Member

@PuneetGopinath PuneetGopinath commented May 24, 2021

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Move all source files a new folder src

Closes #

@PuneetGopinath PuneetGopinath added Priority: low Low priority for this issue/pr. Status: In progress This pr or issue is in progress Type: enhancement New feature or request labels May 24, 2021
@PuneetGopinath PuneetGopinath requested a review from Andre601 May 24, 2021 05:57
@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 24, 2021

Build was not run after last commit. Is there an issue in workflow? @PuneetGopinath

@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 24, 2021

Build was not run after last commit. Is there an issue in workflow? @PuneetGopinath

No issues

@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 24, 2021

No issues

It should have run according to me

@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 24, 2021

It should have run according to me

How?

@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 24, 2021 •
edited
Loading

It should have run according to me

How?

on:
  push:
    paths:
      - "**.js"
      - "**.json"
  workflow_dispatch:

This is the trigger for the workflow. package.json was updated.

@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 24, 2021

This is the trigger for the workflow. package.json was updated.

I don't know what happened but I ran it manually

@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 24, 2021

I think this PR is ready for review.

@PuneetGopinath PuneetGopinath marked this pull request as ready for review May 24, 2021 06:05
@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 24, 2021

I don't know what happened but I ran it manually

But still it didn't commit, if you want you can run it.

@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 24, 2021

The workflow has now triggered.

@PuneetGopinath PuneetGopinath changed the title Use src folder Use src folder and setup airbrake May 24, 2021
@PuneetGopinath PuneetGopinath marked this pull request as draft May 24, 2021 08:50
@PuneetGopinath PuneetGopinath changed the title Use src folder and setup airbrake Use src folder May 24, 2021
@PuneetGopinath PuneetGopinath marked this pull request as ready for review May 24, 2021 09:05
@abhijoshi2k abhijoshi2k removed the request for review from Andre601 May 24, 2021 09:52
@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 24, 2021

@PuneetGopinath can we merge?

@PuneetGopinath PuneetGopinath merged commit fc62664 into main May 24, 2021
@PuneetGopinath PuneetGopinath deleted the src-folder branch May 24, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhijoshi2k abhijoshi2k abhijoshi2k approved these changes

Assignees

No one assigned

Labels

Priority: low Low priority for this issue/pr. Status: In progress This pr or issue is in progress Type: enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PuneetGopinath @abhijoshi2k