Easily get the URL of the issue/comment/pull_request#42
Easily get the URL of the issue/comment/pull_request#42PuneetGopinath merged 14 commits intomainfrom
Conversation
|
The Pull request of @PuneetGopinath has been marked as Ready! It can now be reviewed and/or merged by Maintainers.
|
|
Note: this pr also changes |
|
Will this be a new release or will there be other changes before a new release? |
|
Yes, there should be a new release, @Andre601 Is the issue you opened a bug report or feature request actually, in jamesgeorge007/github-activity-readme#54 |
Feature request |
|
Ok, then next version is |
|
The Pull request of @PuneetGopinath is no longer marked as Ready! Maintainers should wait with merging the Pull request until it is marked as ready again.
|
|
Releasing a new version should be v1.4.0 because, a new feature added means a new minor version, as we are following semver.org |
|
@abhijoshi2k Just waiting for your review |
|
The Pull request of @PuneetGopinath has been marked as Ready! It can now be reviewed and/or merged by Maintainers.
|
|
|
Ok, then as you say will use npm ci |
|
@PuneetGopinath squash and merge this time right? |
|
@abhijoshi2k Sorry, I did it |
Thank you for contributing! Please check the following things before submiting your PR:
Required:
If necessary:
Description
For example, to get issue url you currently use
${urlPrefix}/${item.repo.name}/issues/${item.payload.issue.number}to get the URL of the issue or comment, instead you could easily use${item.payload.issue.html_url}for issue url,${item.payload.pull_request.html_url}for pull request url and${item.payload.comment.html_url}for issue comment url.This pr, will also fulfil a feature request, requested somewhere else: jamesgeorge007/github-activity-readme#54
Closes #
Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.