Skip to content

Add push event documentation#193

Merged
Andre601 merged 4 commits intopush-eventfrom
docs/add-push-event
Jun 7, 2022
Merged

Add push event documentation#193
Andre601 merged 4 commits intopush-eventfrom
docs/add-push-event

Conversation

@Andre601
Copy link
Member

@Andre601 Andre601 commented Jun 7, 2022

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Documentation for the Push Event changes. This PR targets the push-event branch so that we can update the docs alongside the actual workflow when it's ready.

Closes #

@Andre601 Andre601 added Status: Ready The Pull request is ready for reviews and getting merged No changelog Exclude this Pull request from the changelogs labels Jun 7, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

The Pull request of @Andre601 has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

This is an automated response created by a GitHub Action
Mentioning the user won't have any effect!

@Andre601 Andre601 marked this pull request as ready for review June 7, 2022 14:47
@Andre601 Andre601 removed the Status: Ready The Pull request is ready for reviews and getting merged label Jun 7, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

The Pull request of @Andre601 is no longer marked as Ready!

Maintainers should wait with merging the Pull request until it is marked as ready again.

This is an automated response created by a GitHub Action
Mentioning the user won't have any effect!

@Andre601 Andre601 marked this pull request as draft June 7, 2022 14:56
@Andre601 Andre601 added the Status: Ready The Pull request is ready for reviews and getting merged label Jun 7, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

The Pull request of @Andre601 has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

This is an automated response created by a GitHub Action
Mentioning the user won't have any effect!

@Andre601
Copy link
Member Author

Andre601 commented Jun 7, 2022

Sorry for all the spam, but I'm in the process of fixing the commenter action here....

@Andre601 Andre601 mentioned this pull request Jun 7, 2022
Open
4 tasks
abhijoshi2k
abhijoshi2k requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@abhijoshi2k abhijoshi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available placeholders in Messages section does not include {AMOUNT}

@abhijoshi2k
Copy link
Member

abhijoshi2k commented Jun 7, 2022

push-event branch is ready.
Please merge this branch after changes and then merge the push-event branch.
Release new version after that please.
Thanks.

Andre601 and others added 2 commits June 7, 2022 17:15
@Andre601 @abhijoshi2k
Update docs/Configuration.md
81c1ea5 
Co-authored-by: ABHISHEK Joshi <abhijoshi2k@gmail.com>
@Andre601
Add push to list
d76a213
@Andre601
Copy link
Member Author

Andre601 commented Jun 7, 2022

Available placeholders in Messages section does not include {AMOUNT}

I don't get what you mean...
You clearly have {AMOUNT} in the added event as shown in the "Files changed" tab on your PR...

@abhijoshi2k
Copy link
Member

abhijoshi2k commented Jun 7, 2022

Available placeholders in Messages section does not include {AMOUNT}

I don't get what you mean... You clearly have {AMOUNT} in the added event as shown in the "Files changed" tab on your PR...

I'm talking about line 222 (refer file from this branch please)

@Andre601
Copy link
Member Author

Andre601 commented Jun 7, 2022

I'm talking about line 222 (refer file from this branch please)

Still don't get what exactly you want me to change... You can suggest changes to not-altered lines.

@abhijoshi2k
Copy link
Member

abhijoshi2k commented Jun 7, 2022

I'm unable to suggest changes on that line. IDK why.

You can find the line having content:
Available Placeholders are: {DATE}, {ID}, {FORK}, {REPO}, {URL} and {WIKI}

This is to be changed to :
Available Placeholders are: {DATE}, {ID}, {FORK}, {REPO}, {URL}, {AMOUNT} and {WIKI}

@abhijoshi2k
Copy link
Member

abhijoshi2k commented Jun 7, 2022

It's a very small change. If you allow me to push to this branch, I'll do it.
Just let me know

@Andre601 Andre601 marked this pull request as ready for review June 7, 2022 15:28
@Andre601 Andre601 merged commit eae7ab7 into push-event Jun 7, 2022
@abhijoshi2k abhijoshi2k deleted the docs/add-push-event branch June 8, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhijoshi2k abhijoshi2k abhijoshi2k requested changes

Assignees

No one assigned

Labels

No changelog Exclude this Pull request from the changelogs Status: Ready The Pull request is ready for reviews and getting merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andre601 @abhijoshi2k