fix: # of activity lines changes according to max_lines property#160
Conversation
|
This cannot be done because when user changes |
Thanks for the reply, @abhijoshi2k. readmeContent.splice(startIdx, endIdx-startIdx);This line limits the deletion into only |
|
And thanks for the simple solution. |
|
I'll test it once and get back to you. I'm a bit occupied currently. Give me some time. |
|
@jooncco Thanks for the PR. I just tested your edited code. It works as expected. So I think this is ready to be merged. |
|
appreciate it :) |
|
@PuneetGopinath @abhijoshi2k @jooncco I am still facing the issue . I've tried removing the recent activity comment to no avail. It always limits to 5 activities only. Kindly let me know if there's any workaround to it. Thank you. |
|
Did you actually update your settings? |
|
Yes, it's working alright. Needed to change path for the config file ( added custom ). |
Checks
I have...
Type of Pull request
This Pull request doesn't break existing configuration.
This Pull request will break existing configuration.
This Pull request will fix a (critical) bug.
This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
__________Description
This pull request fixes #159.
The number of activity lines will change according to
max_linesproperty every time workflow runs.Closes #159