Skip to content

Add new examples to README#14

Merged
PuneetGopinath merged 3 commits intomainfrom
feature/add-new-readme-examples
May 9, 2021
Merged

Add new examples to README#14
PuneetGopinath merged 3 commits intomainfrom
feature/add-new-readme-examples

Conversation

@Andre601
Copy link
Member

@Andre601 Andre601 commented May 9, 2021

Thank you for contributing! Please check the following things before submiting your PR:

Required:

If necessary:

  • I have updated the README and documentation.
  • I have updated the ChangeLog with the changes I have made.

Added new examples for the README. Please only merge this PR once the actual features have been properly released.

Closes #


Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

@abhijoshi2k
Copy link
Member

Looks good @Andre601 . Thanks for improving the README.
@PuneetGopinath You have any suggestion?

@PuneetGopinath
Copy link
Member

Looks good @Andre601 . Thanks for improving the README.
@PuneetGopinath You have any suggestion?

I don't have any suggestion, you can merge this pr.

@abhijoshi2k
Copy link
Member

abhijoshi2k commented May 9, 2021

@Andre601 Can you add a link to a page having info about how to create profile readme? (for beginners)
Add it at the top.
https://abhijoshi2k.medium.com/how-to-create-a-readme-for-your-github-profile-95e0fc474f49
This will give basic idea to beginners.

@PuneetGopinath
Copy link
Member

@Andre601 Can you add a link to a page having info about how to create profile readme? (for beginners)
Add it at the top.
https://abhijoshi2k.medium.com/how-to-create-a-readme-for-your-github-profile-95e0fc474f49
This will give basic idea to beginners.

Awesome article bro👌👌

@Andre601 just add

## For beginners

If you are a beginner, then see [this guide at medium](https://abhijoshi2k.medium.com/how-to-create-a-readme-for-your-github-profile-95e0fc474f49), Guide written by @abhijoshi2k 

in the top of the readme

@Andre601
Copy link
Member Author

Andre601 commented May 9, 2021

Awesome article bro👌👌

@Andre601 just add

## For beginners

If you are a beginner, then see [this guide at medium](https://abhijoshi2k.medium.com/how-to-create-a-readme-for-your-github-profile-95e0fc474f49), Guide written by @abhijoshi2k 

in the top of the readme

Not so sure about this...
Especially in terms of placement. I changed the text and placement a little bit.

Copy link
Member

@abhijoshi2k abhijoshi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Should we merge this? @PuneetGopinath

@PuneetGopinath
Copy link
Member

Looks good.
Should we merge this? @PuneetGopinath

I requested some changes

@PuneetGopinath PuneetGopinath merged commit c8596e4 into main May 9, 2021
@PuneetGopinath PuneetGopinath deleted the feature/add-new-readme-examples branch May 9, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants