Skip to content

Switch to GitHub-integrated release creator#119

Merged
abhijoshi2k merged 3 commits intomainfrom
feature/use-github-auto-releases
Oct 5, 2021
Merged

Switch to GitHub-integrated release creator#119
abhijoshi2k merged 3 commits intomainfrom
feature/use-github-auto-releases

Conversation

@Andre601
Copy link
Member

@Andre601 Andre601 commented Oct 4, 2021

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: Release system

Description

GitHub released a public beta for the automatic release creation.

Downside of this is, that it will essentially require us to manually update stuff like the version of the release and similar...

Closes #

@Andre601 Andre601 added the Type: enhancement New feature or request label Oct 4, 2021
@Andre601 Andre601 marked this pull request as ready for review October 4, 2021 23:02
@Andre601 Andre601 added the Status: Ready The Pull request is ready for reviews and getting merged label Oct 4, 2021
@ghost
Copy link

ghost commented Oct 4, 2021

The Pull request of @Andre601 has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.


This is an automated response created by a GitHub Action
Mentioning the user won't have any effect!

@PuneetGopinath
Copy link
Member

Wow👏. Have you tested it?

@Andre601
Copy link
Member Author

Andre601 commented Oct 5, 2021

Wow👏. Have you tested it?

Not sure how I could test it...

@PuneetGopinath
Copy link
Member

Wow👏. Have you tested it?

Not sure how I could test it...

I mean have you seen it somewhere? Or tested in any of your repositories

@Andre601
Copy link
Member Author

Andre601 commented Oct 5, 2021

I mean have you seen it somewhere? Or tested in any of your repositories

No. There is always a first time for everything and since that has been released literally yesterday would I doubt many have it already...

Copy link
Member

@PuneetGopinath PuneetGopinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhijoshi2k abhijoshi2k merged commit 80978dc into main Oct 5, 2021
@abhijoshi2k abhijoshi2k deleted the feature/use-github-auto-releases branch October 5, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants