Skip to content

Create CONTRIBUTING.md#2

Merged
PuneetGopinath merged 3 commits intomainfrom
docs/create-contributing-file
Jul 14, 2021
Merged

Create CONTRIBUTING.md#2
PuneetGopinath merged 3 commits intomainfrom
docs/create-contributing-file

Conversation

@Andre601
Copy link
Member

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Adding a general Contributing file to fix issues with PRs linking to non-existing files... (Such as in this case)

Closes #

@Andre601 Andre601 added the Status: Ready This pr is ready for reviews and merging label Jul 13, 2021
@Andre601 Andre601 marked this pull request as ready for review July 13, 2021 16:36
@PuneetGopinath
Copy link
Member

PuneetGopinath commented Jul 14, 2021

@Andre601 If you add it in this repo. Now the same contributing file is going to go to all repos which don't have .github/CONTRIBUTING.md file in this GitHub org.

In this file. You have put "Contributing to recent-activity" which is for recent-activity only

@Andre601
Copy link
Member Author

In this file. You have put "Contributing to recent-activity" which is for recent-activity only

Uhm... No?
The CONTRIBUTING.md has 0 mention of Recent-Activity and if there is, point it out in a change request.

@PuneetGopinath PuneetGopinath merged commit 6dff179 into main Jul 14, 2021
@PuneetGopinath PuneetGopinath deleted the docs/create-contributing-file branch July 14, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Ready This pr is ready for reviews and merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants