fix(fromEvent): allow fromEvent to handle symbols as event names#7339
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Dec 19, 2023
Merged
fix(fromEvent): allow fromEvent to handle symbols as event names#7339benlesh merged 1 commit intoReactiveX:masterfrom
fromEvent to handle symbols as event names#7339benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
c2a2466 to
a9904bf
Compare
Allow passing a value of type `symbol` to `eventName` if a `NodeStyleEventEmitter` is passed to `source`, according to [the documentation](https://nodejs.org/api/events.html#emitteraddlistenereventname-listener). Closes ReactiveX#7338
a9904bf to
15f1979
Compare
benlesh
approved these changes
Dec 19, 2023
Member
|
Thank you, @demensky ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing a value of type
symboltoeventNameif aNodeStyleEventEmitteris passed tosource, according to the documentation.Closes #7338