fix(Subscriber): next method no longer has optional value argument#7290
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Jun 19, 2023
Merged
fix(Subscriber): next method no longer has optional value argument#7290benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
59162c7 to
7518b09
Compare
jakovljevic-mladen
approved these changes
Jun 19, 2023
Contributor
|
I just faced a nasty runtime error that could have been avoided if this fix had already been shipped. I'd like to know: will there be a release patch containing this fix? Or will it be treated as a "breaking change," meaning we'll need to wait for version 8? FWIW, I strongly believe this deserves a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2852
Related #7172