feat(repeat): now has configurable delay#6640
Merged
benlesh merged 2 commits intoReactiveX:masterfrom Dec 27, 2021
Merged
Conversation
Adds a feature to `repeat` to match the configurable API of `retry`. `repeat` can now be used in a similar manner to `repeatWhen`, only perhaps in a more developer-friendly way. - Also updates `repeat` tests to use run mode.
Member
Author
|
related #6367 |
cartant
reviewed
Oct 14, 2021
cartant
approved these changes
Oct 15, 2021
Contributor
|
Doesn't this create unnecessary verbosity?
Let's better update the timer(2000)
.pipe(
tap({
subscribe: () => console.log('subscribe'),
complete: () => console.log('complete'),
}),
repeatWhen(pipe(delay(1000)))
)
.subscribe(() => console.log('next')); |
spec/operators/repeat-spec.ts
Outdated
| const expected = '|'; | ||
| rxTest.run(({ cold, expectObservable, expectSubscriptions }) => { | ||
| const e1 = cold('--a--b--| '); | ||
| const unsub = ' !'; |
Member
There was a problem hiding this comment.
This is not properly converted - though, unsub is not really needed.
thuyit1996
approved these changes
Dec 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature to
repeatto match the configurable API ofretry.repeatcan now be used in a similar manner torepeatWhen, onlyperhaps in a more developer-friendly way.
repeattests to use run mode.