docs(debounce): fix marble diagram#6639
Merged
niklas-wortmann merged 1 commit intoReactiveX:masterfrom Oct 21, 2021
Merged
Conversation
5 tasks
benlesh
approved these changes
Oct 20, 2021
|
|
||
| expectObservable(result).toBe(expected); | ||
| expectSubscriptions(e1.subscriptions).toBe(e1subs); | ||
| expectSubscriptions(e2.subscriptions).toBe(e2subs); |
niklas-wortmann
approved these changes
Oct 21, 2021
Member
niklas-wortmann
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for picking up the work of converting the marble diagrams over to SVG. I very much appreciate it.
Member
Author
|
@niklas-wortmann Thank you for taking your time to review PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix the marble diagram for
debounceoperator so that it now shows thatdebounceacts when a notifying (inner) Observable emits next notification instead of a complete notification.The new image looks like this:
Related issue (if exists):
#6627