Skip to content

docs(audit): fix marble diagram#6636

Merged
niklas-wortmann merged 1 commit intoReactiveX:masterfrom
jakovljevic-mladen:fix_audit_marble_diagram
Oct 21, 2021
Merged

docs(audit): fix marble diagram#6636
niklas-wortmann merged 1 commit intoReactiveX:masterfrom
jakovljevic-mladen:fix_audit_marble_diagram

Conversation

@jakovljevic-mladen
Copy link
Copy Markdown
Member

@jakovljevic-mladen jakovljevic-mladen commented Oct 10, 2021

Description:
Fix the marble diagram for audit operator so that it now shows that audit acts when a notifying (inner) Observable emits next notification instead of a complete notification.

The image looks like this:
New audit marble diagram image

Related issue (if exists):
#6627

const e2 = cold(' ----x ');
const e1 = hot(' -a-xy-----b--x--cxyz-|');
const e1subs = ' ^--------------------!';
const e2 = cold(' ----i ');
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated test so that it follows docs_app/tools/marbles/diagrams/audit.txt.

Copy link
Copy Markdown
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niklas-wortmann niklas-wortmann merged commit 8ad4f69 into ReactiveX:master Oct 21, 2021
@jakovljevic-mladen jakovljevic-mladen deleted the fix_audit_marble_diagram branch October 21, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants