fix(share): propagate closed to firehose sources#6370
Merged
benlesh merged 5 commits intoReactiveX:masterfrom May 6, 2021
Merged
fix(share): propagate closed to firehose sources#6370benlesh merged 5 commits intoReactiveX:masterfrom
benlesh merged 5 commits intoReactiveX:masterfrom
Conversation
benlesh
reviewed
May 6, 2021
| // up _before_ the subscription to the source occurs. This is done so that | ||
| // the assignment to the source connection's `closed` property will be seen | ||
| // by synchronous firehose sources. | ||
| subscriber.add(() => { |
benlesh
reviewed
May 6, 2021
| } | ||
| }); | ||
|
|
||
| synchronousObservable.pipe(shareReplay(), take(3)).subscribe(() => { |
Member
There was a problem hiding this comment.
It seems like we'd still want this test for refCount: true.
benlesh
approved these changes
May 6, 2021
Member
benlesh
left a comment
There was a problem hiding this comment.
Approved. However, I think we may want to add the test back for shareReplay in the refCount: true case.
This was referenced May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes
shareso that it wires up the teardown before subscribing to the source - ensuring the assignment to the subscriber'sclosedproperty is propagated to the firehose source.The skipped firehose test has been enabled and the firehose tests that related to now-deprecated operators have been removed.
Related issue (if exists): #5834 (I've closed this because it related to the now-deprecated APIs)