chore: deprecate thisArg signatures#6361
Merged
benlesh merged 4 commits intoReactiveX:masterfrom May 6, 2021
Merged
Conversation
Member
|
Hmm... it would be great if this worked perfectly... but part of me thinks that it's also okay if we just document it if we can't get this working just right. |
This reverts commit 8bb2f84. Closes ReactiveX#6143.
benlesh
reviewed
May 6, 2021
Member
benlesh
left a comment
There was a problem hiding this comment.
Question: Are we able to test these deprecations with dtslint?
benlesh
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR deprecates the
thisArgsignatures.Unfortunately, the deprecation of predicates that accept a
sourceparameter isn't possible. When the non-deprecated signatures - i.e. those with predicates that do not acceptsourceparameters - are added, the inference breaks and calls that pass source-accepting predicates won't compile - for the dtslint tests - because the parameters are inferred asanyand implicitanyis disallowed. I can guess at what's happening internally - 'cause, normally, you would not have separate signatures - but the inference failure is still weird.The removal of the
sourceparameters will have to be conveyed in documentation instead. Or left as a breaking change surprise.Related issue (if exists): #6143