docs(versioning): add versioning to docs website#5793
Merged
niklas-wortmann merged 1 commit intoReactiveX:6.xfrom Oct 31, 2020
Merged
docs(versioning): add versioning to docs website#5793niklas-wortmann merged 1 commit intoReactiveX:6.xfrom
niklas-wortmann merged 1 commit intoReactiveX:6.xfrom
Conversation
This was referenced Oct 4, 2020
Closed
benlesh
reviewed
Oct 7, 2020
| "rxjs-dev": { | ||
| "hosting": { | ||
| "stable": [ | ||
| "rxjs-dev" |
Member
There was a problem hiding this comment.
I don't actually know much about this configuration. Can you explain what this is doing?
Member
Author
There was a problem hiding this comment.
sure, so we have one firebase project called rxjs-dev, we only use the hosting feature of firebase. Within firebase though we host now one "site" per version and those get an alias. So if you do firebase deploy --only hosting:stable it will deploy the current dist folder in the stable site. It's kinda like an alias for the site that is used within this branch
benlesh
approved these changes
Oct 30, 2020
Member
benlesh
left a comment
There was a problem hiding this comment.
LGTM. Rebase and merge when you're ready.
I think the failure on the "latest" build is expected and we need to figure out how to make it optional on the 6.x branch. 🤔
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.