Issue/5739 smaller operator creation#5742
Merged
benlesh merged 12 commits intoReactiveX:masterfrom Sep 23, 2020
Merged
Conversation
benlesh
commented
Sep 23, 2020
benlesh
commented
Sep 23, 2020
benlesh
commented
Sep 23, 2020
benlesh
commented
Sep 23, 2020
benlesh
commented
Sep 23, 2020
cartant
requested changes
Sep 23, 2020
Collaborator
cartant
left a comment
There was a problem hiding this comment.
LGTM, but there are a bunch of return statements in the operators that I think aren't needed. And I have a few nitpicks.
tonivj5
reviewed
Sep 23, 2020
Member
Author
|
HA! While fixing the stuff @cartant pointed out, I updated |
cartant
approved these changes
Sep 23, 2020
…in a selector appropriately - Also refactors multicast to use the new `operate` mechanism.
…scription in operate.
…tions can no longer be returned This will help force us to make sure we are using the subscriber and subscription chaining in the most efficient way possible. Although it could result in anti-patterns where users return a function that calls unsubscribe on a subscription if we release this to the public.
f73e056 to
7c694b6
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operatefunction for creating operatorsliftandwrappedLifthelpers.publishReplayet al, where an error thrown in the selector function was being thrown externally instead of send to the subscriber via an error notification.Further size reduction.
57K -> 55K57K -> 54K approximately