feat(retry): add config to reset error count on successful emission#4683
Closed
omermizr wants to merge 3 commits intoReactiveX:masterfrom
Closed
feat(retry): add config to reset error count on successful emission#4683omermizr wants to merge 3 commits intoReactiveX:masterfrom
omermizr wants to merge 3 commits intoReactiveX:masterfrom
Conversation
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of fb7bb58. Here's the output:
|
fb7bb58 to
c4d20c0
Compare
Pull Request Test Coverage Report for Build 8312
💛 - Coveralls |
Member
|
@cartant said we can have this. 👍 |
benlesh
requested changes
May 10, 2019
Member
benlesh
left a comment
There was a problem hiding this comment.
Okay... I think we're almost there. Here's what I think we should do though... instead of having two arguments, we have it take either a number or a config object like so:
retry(); // retry forever
retry(5); // retry five times
retry({ count: 5 }); // retry five times
retry({ count: 5, resetOnSuccess: true }); // retry five times, but reset the counter on success
retry{{ resetOnSuccess: true }); // This is the same thing as just retry() lol
Author
|
Something to consider (breaking changes aside ): I think that |
added 2 commits
May 12, 2019 12:14
This PR adds the ability to reset the error counter on successful emissions using the `retry` operator. The current behavior for `retry(n)` is to call error if n errors occurred, regardless of whether or not they were consecutive. Now one would be able to use `retry(n, true)` to have the count reset so that only n consecutive errors will cause the observable to fail.
added overloaded signature to the `retry` operator that accepts a config object
c4d20c0 to
8815014
Compare
Author
|
@benlesh ping, I made the suggested changes |
benlesh
requested changes
Aug 1, 2019
Member
benlesh
left a comment
There was a problem hiding this comment.
Just a couple of small things.
Author
|
@benlesh ping |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to reset the error counter on successful emissions using the
retryoperator.
Description:
The current behavior for
retry(n)is to call error if n errors occurred, regardless ofwhether or not they were consecutive. Now one would be able to use
retry(n, true)to have thecount reset so that only n consecutive errors will cause the observable to fail.