chore(typings): add type guard overloads for first/last#3902
Merged
benlesh merged 5 commits intoReactiveX:masterfrom Jul 13, 2018
Merged
chore(typings): add type guard overloads for first/last#3902benlesh merged 5 commits intoReactiveX:masterfrom
benlesh merged 5 commits intoReactiveX:masterfrom
Conversation
3f99bf8 to
7a16ca6
Compare
benlesh
approved these changes
Jul 13, 2018
Member
|
👍 |
Member
|
Oops... just noticed after I merged this... next time this should be labelled a "fix" so it shows up in the change log, since it's an improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Uncomments the tests that were skipped when enabling type checking for the test suite. And adds overload signatures with type guards to
firstandlast.Note that because the predicates are optional, additional overload signatures that match calls made with no arguments or with a
nullorundefinedpredicate are required. Otherwise, theStype parameter is inferred as{}and the type of the output observable becomesObservable<{}>.Related issue (if exists): #3717