perf: remove comments from js-files#3760
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Jun 4, 2018
csvn:reduce-disk-size
Merged
perf: remove comments from js-files#3760benlesh merged 1 commit intoReactiveX:masterfrom csvn:reduce-disk-size
benlesh merged 1 commit intoReactiveX:masterfrom
csvn:reduce-disk-size
Conversation
Strip comments from all .js files (except legacy-reexports and compat) while retaining them for .d.ts files. The legacy-reexport does not have any comments and will be removed with compat in next major version. ``` npx get-folder-size --folder=dist/package // 5.88 Mb (with comments) // 4.63 Mb (without comments) ``` Roughly 1.25 Mb is saved by removing comments.
Contributor
Author
|
If you are wondering why |
benlesh
approved these changes
May 31, 2018
Member
|
LGTM... @cartant second opinion? |
Member
|
Thanks @csvn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Strip comments from all
.jsfiles (exceptlegacy-reexportsandcompat) while retaining them for.d.tsfiles. Thelegacy-reexportdoes not have any comments and will be removed withcompatin next major version.Roughly 1.25 Mb is saved by removing comments.
Related issue (if exists): #3753