fix(mergeAll): add source subscription to composite before actually subscribing#2479
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Jul 26, 2018
mpodlasin:fix-merge-all-inner-subscriptions
Merged
fix(mergeAll): add source subscription to composite before actually subscribing#2479benlesh merged 1 commit intoReactiveX:masterfrom mpodlasin:fix-merge-all-inner-subscriptions
benlesh merged 1 commit intoReactiveX:masterfrom
mpodlasin:fix-merge-all-inner-subscriptions
Conversation
benlesh
requested changes
Mar 21, 2017
Member
benlesh
left a comment
There was a problem hiding this comment.
Just some clarification around a comment.
spec/operators/mergeAll-spec.ts
Outdated
| () => results.push('GOOSE!') | ||
| ); | ||
|
|
||
| // never even get here |
Member
There was a problem hiding this comment.
This comment is confusing. Why wouldn't it get here?
Contributor
Author
|
@benlesh done. |
benlesh
approved these changes
Mar 30, 2018
…ubscribing Add subscriptions for source Observables to mergeAll composite subscription before actually subscribing to any of these Observables, so that if source Observable emits synchronously and consumer of mergeAll unsubscribes at that moment (for example `take` operator), subscription to source is unsubscribed as well and Observable stops emitting. Closes #2476
Collaborator
|
@benlesh I've rebased and refactored this PR. |
benlesh
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add subscriptions for source Observables to mergeAll composite subscription before actually subscribing to any of these Observables, so that if source Observable emits synchronously and consumer of mergeAll unsubscribes at that moment (for example
takeoperator), subscription to source is unsubscribed as well and Observable stops emitting.Closes #2476