Skip to content

Marble diagram for delay() is incorrect in documentation #6741

@martinsik

Description

@martinsik

Describe the bug

I'm preparing some RxJS guide for Angular devs and I've noticed that the marble diagram image for delay() is wrong. It looks like it delays also the complete notification which it shouldn't.

I tested this also on stackblitz to make sure it doesn't delay complete notification: https://stackblitz.com/edit/rxjs-rtppth?devtoolsheight=60
The same scenario as in the marble diagram seems to be in unit tests where it doesn't expect complete to be delayed. https://github.com/ReactiveX/rxjs/blob/master/spec/operators/delay-spec.ts#L18

I've noticed that marble diagrams are now generated using swirly and should be defined in txt files in docs_app/tools/marbles/diagrams (?) but I guess I don't know how the process works any more (last time I checked it was generated from unit tests :)). The images in the docs come from docs_app/src/assets/images/marble-diagrams so I guess they are 2 years old and might be outdated (?).

Expected behavior

Marble diagram for delay() should reflect expected behavior as in unit tests https://github.com/ReactiveX/rxjs/blob/master/spec/operators/delay-spec.ts#L23

Reproduction code

No response

Reproduction URL

https://stackblitz.com/edit/rxjs-rtppth?devtoolsheight=60

Version

latest docs

Environment

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions