Skip to content

Unsubscribe is slow when observers number > 10000 #5638

Closed
Closed
Unsubscribe is slow when observers number > 10000#5638
@zxch3n

Description

@zxch3n
zxch3n
opened on Aug 8, 2020

Both of indexOf and splice are slow. Why not use a Set to store observers?

rxjs/src/internal/SubjectSubscription.ts

Lines 17 to 39 in 40b32d8

unsubscribe() {
if (this.closed) {
return;
}
this.closed = true;
const subject = this.subject;
const observers = subject.observers;
this.subject = null!;
if (!observers || observers.length === 0 || subject.isStopped || subject.closed) {
return;
}
const subscriberIndex = observers.indexOf(this.subscriber);
if (subscriberIndex !== -1) {
observers.splice(subscriberIndex, 1);
}
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions