Skip to content

2.x: Remove unnecessary static imports from unit tests #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Jun 28, 2019
Merged

2.x: Remove unnecessary static imports from unit tests #6545

akarnokd merged 1 commit into from
Jun 28, 2019

Conversation

@slievrly
Copy link
Contributor

@slievrly slievrly commented Jun 27, 2019 •
edited by akarnokd
Loading

2.x: Remove unnecessary static imports from unit tests.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #6545 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6545      +/-   ##
============================================
- Coverage     98.27%   98.24%   -0.03%     
+ Complexity     6336     6333       -3     
============================================
  Files           677      677              
  Lines         45486    45486              
  Branches       6319     6319              
============================================
- Hits          44702    44689      -13     
- Misses          241      249       +8     
- Partials        543      548       +5
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.27% <0%> (-3.39%) 2% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-2.24%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.19%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 95.72% <0%> (-1.71%) 2% <0%> (ø)
...internal/operators/flowable/FlowableSwitchMap.java 95.28% <0%> (-1.42%) 3% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df3285...e84af1b. Read the comment docs.

@akarnokd akarnokd changed the title remove unnecessary import 2.x: Remove unnecessary static imports from unit tests Jun 27, 2019
@akarnokd akarnokd added this to the 2.2 backlog milestone Jun 27, 2019
@akarnokd akarnokd merged commit 67b9cf6 into ReactiveX:2.x Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Cleanup Test

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@slievrly @akarnokd @vanniktech