Skip to content

Expand Observable#debounce and Flowable#debounce javadoc #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Jan 23, 2019
Merged

Expand Observable#debounce and Flowable#debounce javadoc #6377

akarnokd merged 1 commit into from
Jan 23, 2019

Conversation

@RomanWuattier
Copy link
Contributor

@RomanWuattier RomanWuattier commented Jan 19, 2019

Mention that if the processing of a task takes too long
and a newer item arrives then the previous task will
get disposed interrupting a long running work.

Fixes: #6288

akarnokd
akarnokd requested changes Jan 19, 2019
View reviewed changes
Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduler wording needs to be adapted to the particular overload.

@akarnokd akarnokd added this to the 2.2 backlog milestone Jan 19, 2019
@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #6377 into 2.x will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6377      +/-   ##
============================================
- Coverage     98.25%   98.16%   -0.09%     
+ Complexity     6292     6286       -6     
============================================
  Files           673      673              
  Lines         45092    45092              
  Branches       6239     6239              
============================================
- Hits          44306    44266      -40     
- Misses          248      274      +26     
- Partials        538      552      +14
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 542 <0> (ø) ⬇️
...ex/internal/operators/flowable/FlowableCreate.java 90% <0%> (-7.1%) 6% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 91.5% <0%> (-4.58%) 2% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 90.42% <0%> (-3.2%) 9% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ex/internal/subscriptions/SubscriptionArbiter.java 97.47% <0%> (-2.53%) 50% <0%> (-1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <0%> (-2.14%) 5% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40f923...fe02fc2. Read the comment docs.

@RomanWuattier RomanWuattier force-pushed the expand-debounce-javadoc-observable-flowable branch from bb96222 to 1abd83f Compare January 19, 2019 16:53
@RomanWuattier
Copy link
Contributor Author

RomanWuattier commented Jan 19, 2019

Thanks for the review. Done.

akarnokd
akarnokd reviewed Jan 19, 2019
View reviewed changes
akarnokd
akarnokd reviewed Jan 19, 2019
View reviewed changes
@RomanWuattier RomanWuattier force-pushed the expand-debounce-javadoc-observable-flowable branch 2 times, most recently from 015055f to fa8a161 Compare January 19, 2019 19:28
@RomanWuattier
Expand Observable#debounce and Flowable#debounce javadoc
fe02fc2 
Mention that if the processing of a task takes too long
and a newer item arrives then the previous task will
get disposed interrupting a long running work.

Fixes: ReactiveX#6288
@RomanWuattier RomanWuattier force-pushed the expand-debounce-javadoc-observable-flowable branch from fa8a161 to fe02fc2 Compare January 19, 2019 19:32
@RomanWuattier
Copy link
Contributor Author

RomanWuattier commented Jan 23, 2019

Thanks, the wording for selector-based debounces is updated.

@akarnokd akarnokd merged commit 3fbfcc9 into ReactiveX:2.x Jan 23, 2019
@akarnokd akarnokd mentioned this pull request Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Documentation

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@RomanWuattier @akarnokd @vanniktech