2.x: Add interruptible mode to Schedulers.from #6370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #6370 +/- ##
============================================
- Coverage 98.24% 98.18% -0.07%
- Complexity 6282 6287 +5
============================================
Files 673 673
Lines 45023 45075 +52
Branches 6226 6239 +13
============================================
+ Hits 44235 44256 +21
- Misses 248 263 +15
- Partials 540 556 +16
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
Schedulers.fromuses a trampoline to ensure worker tasks are executed FIFO and non-overlappingly on any potentially multi-threadedExecutor. This old setup didn't allow task interruption due to this disconnect between the trampoline task and the operator task. (In contrast, the standard schedulers use single threaded executors and theirFutureis linked and interruptible when the operator task is cancelled).This PR add an interruptible mode to the
Schedulers.fromvia a paramerer in a new overload and some internal dispatching based on this mode selector. ExistingSchedulers.from(Executor)users should still behave the same.Resolves: #6368