Skip to content

Inline SubscriptionHelper.isCancelled() #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Oct 28, 2018
Merged

Inline SubscriptionHelper.isCancelled() #6263

akarnokd merged 1 commit into from
Oct 28, 2018

Conversation

@artem-zinnatullin
Copy link
Contributor

@artem-zinnatullin artem-zinnatullin commented Oct 28, 2018

Addresses #6258 (comment)

@artem-zinnatullin artem-zinnatullin mentioned this pull request Oct 28, 2018
Merged
@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #6263 into 2.x will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6263      +/-   ##
============================================
- Coverage     98.25%   98.24%   -0.02%     
- Complexity     6208     6209       +1     
============================================
  Files           667      667              
  Lines         44898    44897       -1     
  Branches       6219     6226       +7     
============================================
- Hits          44116    44107       -9     
- Misses          242      245       +3     
- Partials        540      545       +5
Impacted Files Coverage Δ Complexity Δ
...vex/internal/subscriptions/SubscriptionHelper.java 100% <ø> (ø) 36 <0> (-2) ⬇️
...x/internal/subscribers/ForEachWhileSubscriber.java 97.61% <0%> (-2.39%) 11 <1> (ø)
...x/internal/operators/flowable/FlowableTimeout.java 99.38% <0%> (-0.62%) 3 <0> (ø)
...a/io/reactivex/subscribers/ResourceSubscriber.java 100% <100%> (ø) 11 <2> (+1) ⬆️
...operators/flowable/FlowableWithLatestFromMany.java 100% <100%> (ø) 7 <0> (ø) ⬇️
...perators/flowable/FlowableSequenceEqualSingle.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...rnal/operators/maybe/MaybeDelayOtherPublisher.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...activex/internal/subscribers/FutureSubscriber.java 100% <100%> (ø) 33 <2> (+1) ⬆️
...internal/operators/flowable/FlowableGroupJoin.java 95.3% <100%> (ø) 2 <0> (ø) ⬇️
...l/operators/flowable/BlockingFlowableIterable.java 100% <100%> (ø) 2 <0> (ø) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a774e6...95f9419. Read the comment docs.

@akarnokd akarnokd merged commit 7849fc9 into ReactiveX:2.x Oct 28, 2018
@akarnokd akarnokd mentioned this pull request Nov 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artem-zinnatullin @akarnokd @vanniktech