Skip to content

2.x: Add Completable.delaySubscription marble, fix some javadoc #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Oct 19, 2018
Merged

2.x: Add Completable.delaySubscription marble, fix some javadoc #6257

akarnokd merged 1 commit into from
Oct 19, 2018

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 19, 2018

  • Add marbles to the new Completable.delaySubscription operator.
  • Fix the method name referenced in the ConditionalSubscriber javadoc.

image
image

@akarnokd akarnokd added this to the 2.2 backlog milestone Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #6257 into 2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6257      +/-   ##
============================================
- Coverage     98.28%   98.26%   -0.02%     
+ Complexity     6206     6202       -4     
============================================
  Files           667      667              
  Lines         44889    44889              
  Branches       6216     6216              
============================================
- Hits          44117    44112       -5     
- Misses          240      241       +1     
- Partials        532      536       +4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 119 <0> (ø) ⬇️
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 92.15% <0%> (-1.97%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...io/reactivex/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.2% <0%> (-0.97%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 98.2% <0%> (-0.9%) 59% <0%> (-1%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378cbf9...9fb98cd. Read the comment docs.

@akarnokd akarnokd merged commit c358741 into ReactiveX:2.x Oct 19, 2018
@akarnokd akarnokd deleted the JavaDocCleanup1019 branch October 19, 2018 20:16
codefromthecrypt
codefromthecrypt reviewed Oct 20, 2018
View reviewed changes
src/main/java/io/reactivex/internal/fuseable/ConditionalSubscriber.java

/**
* A Subscriber with an additional onNextIf(T) method that
* A Subscriber with an additional {@link #tryOnNext(Object)} method that
Copy link

@codefromthecrypt codefromthecrypt Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks was going to raise this :P

codefromthecrypt
codefromthecrypt reviewed Oct 20, 2018
View reviewed changes
src/main/java/io/reactivex/internal/fuseable/ConditionalSubscriber.java
* A Subscriber with an additional {@link #tryOnNext(Object)} method that
* tells the caller the specified value has been accepted or
* not.
*
Copy link

@codefromthecrypt codefromthecrypt Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate topic, but when reading this I was wondering if we should call out pattern/antipattern for calling tryOnNext and also onNext. Is there a case where this should happen? If so, or not, would that description end up in javadoc or somewhere else?

Copy link
Member Author

@akarnokd akarnokd Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mixing. See Flowable's fromArray and filter for usage examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt left review comments

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Documentation

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@akarnokd @codefromthecrypt @vanniktech