Skip to content

2.x: Cleanup code style, commas, spaces, docs #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Oct 19, 2018
Merged

2.x: Cleanup code style, commas, spaces, docs #6255

akarnokd merged 1 commit into from
Oct 19, 2018

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 19, 2018

  • Add missing spaces after commas and semicolons
  • Add or fix first sentences without commas in javadocs

@akarnokd akarnokd added this to the 2.2 backlog milestone Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #6255 into 2.x will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #6255      +/-   ##
===========================================
- Coverage     98.27%   98.2%   -0.07%     
+ Complexity     6206    6204       -2     
===========================================
  Files           667     667              
  Lines         44889   44889              
  Branches       6216    6216              
===========================================
- Hits          44114   44084      -30     
- Misses          246     259      +13     
- Partials        529     546      +17
Impacted Files Coverage Δ Complexity Δ
...va/io/reactivex/internal/util/ExceptionHelper.java 100% <ø> (ø) 18 <0> (ø) ⬇️
...x/internal/operators/flowable/FlowableGroupBy.java 95.51% <ø> (ø) 3 <0> (ø) ⬇️
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <ø> (ø) 9 <0> (ø) ⬇️
...reactivex/internal/schedulers/SingleScheduler.java 92.94% <ø> (ø) 15 <0> (ø) ⬇️
...reactivex/internal/queue/SpscLinkedArrayQueue.java 97.61% <100%> (ø) 39 <1> (ø) ⬇️
...va/io/reactivex/internal/queue/SpscArrayQueue.java 100% <100%> (ø) 23 <0> (ø) ⬇️
...java/io/reactivex/processors/UnicastProcessor.java 100% <100%> (ø) 68 <1> (ø) ⬇️
...a/io/reactivex/internal/queue/MpscLinkedQueue.java 100% <100%> (ø) 18 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 86.27% <0%> (-9.16%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb9504...967800d. Read the comment docs.

vanniktech
vanniktech approved these changes Oct 19, 2018
View reviewed changes
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice

@akarnokd akarnokd merged commit 378cbf9 into ReactiveX:2.x Oct 19, 2018
@akarnokd akarnokd deleted the SpaceAfterComma branch October 19, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Cleanup

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@akarnokd @vanniktech