Skip to content

2.x: Assert instead of print Undeliverable in some tests #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 2 commits into from
Sep 7, 2018
Merged

2.x: Assert instead of print Undeliverable in some tests #6205

akarnokd merged 2 commits into from
Sep 7, 2018

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 7, 2018

Set plugin error tracking in some tests to avoid printing out UndeliverableExceptions (sometimes repeatedly in race tests) and assert the specific exception(s) instead.

@akarnokd akarnokd added this to the 2.2 backlog milestone Sep 7, 2018
@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #6205 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6205      +/-   ##
============================================
- Coverage     98.23%   98.22%   -0.01%     
  Complexity     6200     6200              
============================================
  Files           667      667              
  Lines         44888    44888              
  Branches       6218     6218              
============================================
- Hits          44094    44093       -1     
  Misses          252      252              
- Partials        542      543       +1
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ex/internal/subscriptions/SubscriptionArbiter.java 94.91% <0%> (-2.55%) 46% <0%> (-1%)
...perators/mixed/ObservableConcatMapCompletable.java 97.74% <0%> (-2.26%) 3% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.44% <0%> (-2.13%) 11% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...internal/operators/flowable/FlowableFromArray.java 94.91% <0%> (-1.7%) 3% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 95.21% <0%> (-1.07%) 3% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc45975...b6237c8. Read the comment docs.

@akarnokd akarnokd merged commit b9c00a8 into ReactiveX:2.x Sep 7, 2018
@akarnokd akarnokd deleted the TestsLessErrorPrintout907 branch September 7, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Cleanup Test

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@akarnokd @vanniktech