fix: open/show debounce preventing tooltip from closing properly#1147
Merged
gabrieljablonski merged 3 commits intoReactTooltip:masterfrom Jan 15, 2024
Merged
Conversation
There was an issue where the tooltip would stay open after the cursor had already left the anchor element. The issue would arise if: - there are two tooltip anchors A and B (same tooltip ID) - mouse goes over A to show the tooltip, user waits for tooltip to show - mouse quickly (within 50ms) leaves A, goes over B, then leaves B. The tooltip component applies debouncing on the show and hide events in case e.g. an anchor is simultaneously focused and mouseovered. If the second leave event occurred while that debounce was still active, it was never processed. This commit fixes the issue by making the show and hide debounce functions reset each other. For example, if the hide debounce has an active timeout, calling the debounced show function will now reset the timeout of the hide debounce. This solution still leaves the hide/show debounces effective against double-show/double-hide.
gabrieljablonski
approved these changes
Jan 2, 2024
Member
gabrieljablonski
left a comment
There was a problem hiding this comment.
Looks good! Should be merged soon.
danielbarion
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1144
There was an issue where the tooltip would stay open after the cursor
had already left the anchor element. The issue would arise if:
The tooltip component applies debouncing on the show and hide events in
case e.g. an anchor is simultaneously focused and mouseovered. If the
second leave event occurred while that debounce was still active, it was
never processed.
This commit fixes the issue by making the show and hide debounce
functions reset each other. For example, if the hide debounce has an
active timeout, calling the debounced show function will now reset the
timeout of the hide debounce.
This solution still leaves the hide/show debounces effective against
double-show/double-hide.