[WIP] Shadow DOM issues research #1068
Closed
quentin-benyahia wants to merge 3 commits intoReactTooltip:masterfrom
Closed
[WIP] Shadow DOM issues research #1068quentin-benyahia wants to merge 3 commits intoReactTooltip:masterfrom
quentin-benyahia wants to merge 3 commits intoReactTooltip:masterfrom
Conversation
Member
|
Thanks for taking the initiative. This is a slightly more complex issue, and since Shadow DOM usage is not super popular, it will probably be a while until we have the time to get to this. But feel free to keep sharing your findings and let us know if you run into any problems. |
3 tasks
Author
|
@gabrieljablonski Meet a bunch of issues indeed to make it work properly, in the meantime just going to fork and make it work for our use cases, I'll close this PR and come back to you if there's anything interesting, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to bug #1029
Some use cases seem to be fixed like the hover, the code isn't perfect but just trying to make some things work.