Skip to content

fix: Show total count of patches instead of just the executed ones#3391

Merged
secp192k1 merged 1 commit into
ReVanced:devfrom
SodaWithoutSparkles:patch-1
Jun 4, 2026
Merged

fix: Show total count of patches instead of just the executed ones#3391
secp192k1 merged 1 commit into
ReVanced:devfrom
SodaWithoutSparkles:patch-1

Conversation

@SodaWithoutSparkles

Copy link
Copy Markdown
Contributor

Updated text to show total steps instead of filtered steps, so the denominator is stable.

Fixes #3028

Updated text to show total steps instead of filtered steps, so the denominator is stable
@SodaWithoutSparkles SodaWithoutSparkles changed the title Change displayed step count to total steps fix(ui): Change displayed step count to total steps Jun 2, 2026
@oSumAtrIX

Copy link
Copy Markdown
Member

Man I recall there was a good reason why it was the way it was now, but I can't remember it and since there's no comment saying why, this lgtm lol

@oSumAtrIX oSumAtrIX requested a review from Axelen123 June 2, 2026 20:14
@oSumAtrIX oSumAtrIX changed the title fix(ui): Change displayed step count to total steps fix: Show total count of patches instead of just the executed ones. Jun 2, 2026
@oSumAtrIX oSumAtrIX changed the title fix: Show total count of patches instead of just the executed ones. fix: Show total count of patches instead of just the executed ones Jun 2, 2026
@secp192k1

Copy link
Copy Markdown
Member

Man I recall there was a good reason why it was the way it was now, but I can't remember it and since there's no comment saying why, this lgtm lol

iirc it was something along the lines that the patcher process was unpredictable - dont quote me on this tho

@Ushie

Ushie commented Jun 3, 2026

Copy link
Copy Markdown
Member

Thanks Soda

@PalmDevs

PalmDevs commented Jun 3, 2026

Copy link
Copy Markdown
Member

Man I recall there was a good reason why it was the way it was now, but I can't remember it and since there's no comment saying why, this lgtm lol

iirc it was something along the lines that the patcher process was unpredictable - dont quote me on this tho

I think that's for sorting the patches/displaying them all before they're completed. Not necessarily the step size.

@secp192k1

Copy link
Copy Markdown
Member

tested and works wondefully, thanks Soda 💖

@secp192k1 secp192k1 merged commit 34736dd into ReVanced:dev Jun 4, 2026
github-actions Bot pushed a commit that referenced this pull request Jun 4, 2026
# app [2.7.0-dev.6](v2.7.0-dev.5...v2.7.0-dev.6) (2026-06-04)

### Bug Fixes

* Show total count of patches instead of just the executed ones ([#3391](#3391)) ([34736dd](34736dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants