Skip to content

feat: Add share button for patched apk#3350

Merged
validcube merged 4 commits into
devfrom
feat/share-patched
May 17, 2026
Merged

feat: Add share button for patched apk#3350
validcube merged 4 commits into
devfrom
feat/share-patched

Conversation

@secp192k1

@secp192k1 secp192k1 commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Just adds a share button on the patcher screen.
Pretty useful for installing with another app (wink wink)

It's using the default output.apk filename because:

  1. Keep changes to a minimum
  2. There would need a good chuck of changes for it to be possible
  3. It doesn't need to have a pretty name, if the user wanted a pretty name they should use the Export/Save button anyways
image image image

@secp192k1 secp192k1 requested review from PalmDevs, Ushie and oSumAtrIX May 13, 2026 19:52
@Ushie

Ushie commented May 13, 2026

Copy link
Copy Markdown
Member

Share button is fine, I'm surprised we didn't have one infact

But if your purpose is what's implied within that wink wink, then an option in settings to use intent-based installation instead of session would be better UX

@Ushie

Ushie commented May 13, 2026

Copy link
Copy Markdown
Member

As for the output name, you could use the same name used by exporting the patch log file

@secp192k1

secp192k1 commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

[...] an option in settings to use intent-based installation instead of session would be better UX

I guess? Although if the output.apk becomes a coherent filename, then a share button would be nice anyways imo

As for the output name, you could use the same name used by exporting the patch log file

fun logFileName() = "revanced_patcher_${packageName}_${version}_${System.currentTimeMillis()}.txt"
Instead of that, which has "patcher" (not "patched") and its huge because of the unix timestamp, not even considering the .txt at the end
Perhaps make it the same as the export apk name?
"${viewModel.packageName}_${viewModel.version}_revanced_patched.apk"

@Ushie

Ushie commented May 13, 2026

Copy link
Copy Markdown
Member

Sure looks perfect

@oSumAtrIX

oSumAtrIX commented May 13, 2026

Copy link
Copy Markdown
Member

Share should replace save, because sharing to files is the standardized way making save redundant

@oSumAtrIX

oSumAtrIX commented May 13, 2026

Copy link
Copy Markdown
Member
image

For some reason the perceived size is different than the other icons for me

@secp192k1

secp192k1 commented May 13, 2026

Copy link
Copy Markdown
Member Author
image

For some reason the perceived size is different than the other icons for me

image image

insane, its really really hard to see but yeah there is a size discrepancy

@PalmDevs

PalmDevs commented May 14, 2026

Copy link
Copy Markdown
Member

Material Icons moment

@validcube validcube changed the title feat(PatcherScreen): Add share button for patched apk feat: Add share button for patched apk May 14, 2026
validcube
validcube reviewed May 14, 2026
View reviewed changes

@validcube validcube left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me (aside from one general comment), although it would be good if the APK name is the same as APK content but if that's too much work we could add a TODO comment or file a feature request for it.

If resolved, I'll go ahead, and approve it, then merge it after 24 hours has passed. (Assuming there are no more review/requested changes after this from other designated reviewers; of course.)

Comment thread app/src/main/java/app/revanced/manager/util/Util.kt
secp192k1 added 2 commits May 15, 2026 21:55
@secp192k1
feat: Replace placeholder with the actual APK info
3b72fbf 
Also the `version` type is `String?` so might as well add a failsafe for that if its somehow missing (???)
@secp192k1
fix: Share icon size
b4116ed
@secp192k1

secp192k1 commented May 15, 2026

Copy link
Copy Markdown
Member Author

3b72fbf
image

b4116ed
image

validcube
validcube approved these changes May 16, 2026
View reviewed changes

@validcube validcube left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 LGTM, merge on queue when 24hrs passed.

@PalmDevs

PalmDevs commented May 16, 2026

Copy link
Copy Markdown
Member

Can we put the share button next to the save button

@Axelen123

Axelen123 commented May 17, 2026

Copy link
Copy Markdown
Member

The share won't work after the file is deleted, but I guess that won't be a problem as long as the target app consumes the file promptly.

@secp192k1

secp192k1 commented May 17, 2026

Copy link
Copy Markdown
Member Author

Can we put the share button next to the save button

yes we can 4266d04

@validcube validcube merged commit 51c8d1f into dev May 17, 2026
1 check passed
github-actions Bot pushed a commit that referenced this pull request May 17, 2026
@semantic-release-bot
chore: Release v2.7.0-dev.1 [skip ci]
11bc430 
# app [2.7.0-dev.1](v2.6.1-dev.3...v2.7.0-dev.1) (2026-05-17)

### Features

* Add share button for patched apk ([#3350](#3350)) ([51c8d1f](51c8d1f))
@secp192k1 secp192k1 deleted the feat/share-patched branch May 19, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axelen123 Axelen123 Axelen123 approved these changes

@validcube validcube validcube approved these changes

@PalmDevs PalmDevs Awaiting requested review from PalmDevs

@oSumAtrIX oSumAtrIX Awaiting requested review from oSumAtrIX

@Ushie Ushie Awaiting requested review from Ushie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@secp192k1 @Ushie @oSumAtrIX @PalmDevs @Axelen123 @validcube