-
Notifications
You must be signed in to change notification settings - Fork 97
Review Request: Senden Schuecker Hahne Diesmann Goebel #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Request: Senden Schuecker Hahne Diesmann Goebel #46
Conversation
|
Thanks for your submission. An editor will be assigned soon. |
|
@otizonaizit Can you edit this submission ? |
1 similar comment
|
@otizonaizit Can you edit this submission ? |
|
sure! |
|
@heplesser : could you review this submission? |
|
@apdavison : could you review this submission? |
|
Possible conflict of interest: I'm a co-PI with Markus Diesmann on a grant (Human Brain Project) |
@apdavison : if you were not involved in the work leading to the present submission this is fine, in my opinion, but let's see what @rougier thinks about it... |
|
by the way, @heplesser may be in a similar conflict, but again, if @rougier agrees with me, I see no conflict of interest if @heplesser was not involved in the work leading to the present submission |
…/github.com/Msenden/ReScience-submission into senden-schuecker-hahne-diesmann-goebel-2018
|
@otizonaizit Following your recommendations, we have added the full code of nest v2.16.0-beta to the submission (within the new folder named We also extended the introduction to provide more thorough background as to why we opted to use NEST. With regard to the point of why we consider recently added features tested well enough for readers/reviewers to trust them, we consider the internal review process of the NEST initiative very reliable. More important to the present discussion, however, we would argue that it is precisely through (numerous) successful re-implementations of existing models that the community can get an independent indication as to whether a software tool is reliable. |
|
@MSenden : thank you for the changes! They look good and will help a lot in the review process! |
|
@otizonaizit Gentle reminder. |
|
@apdavison , @gdetor : do you have a timeline for your review? :) |
|
@otizonaizit I'm sorry for the delay. I'll try to finish the review by next week. |
|
Hi @apdavison , are you still on this? Do you have an approximate timeline for the review? Thanks! |
|
@otizonaizit yes, sorry for not replying sooner. I have installed everything and run the simulations; everything seems fine, so I now need to review the code. Unfortunately I have a major deadline for a grant in one week, so I won't be able to finish the review until the first week in April. |
|
The authors reliably reproduced the results of [A Neural Model of the Saccade Generator in the Reticular Formation]. The source code runs smoothly and with no problems and the text is well-written. General comments
Text
Typos:
Figures
Code
|
|
I am satisfied that this submission is a full replication of the Gancarz and Grossberg technical report. Installing NEST was straightforward. I adapted the Python scripts very slightly so they would run with Python 3 (replaced I skimmed through the C++ code that was added to NEST for this model, and studied two of the model implementations more closely, without finding any problems. I think the code should be adapted to run with both Python 2.7 and 3.6 (Python 2.7 will reach end-of-life in about 20 months from now). As both I and @gdetor found, this is trivial to do using either |
|
@apdavison @gdetor : thank you for your reviews! |
…ation of time vector, comply with PEP8, enable code to run with Python3 (using import), corrected typos
…ed explanation subscripts, corrected typos
|
We would like to thank @apdavison @gdetor for taking the time to review our manuscript and their helpful comments. In what follows we provide a point by point response to the issues raised by the reviewers. Reviewer 1General comments
We are sorry for this shortcoming in the description of our methods. We are familiar with the plot digitizer and the original version of the manuscript indeed uses the tool to extract individual data points from figures 6, 9 and 10 of the original publication. The revised version of the manuscript now mentions this explicitly and describes in more detail the exact information we obtain from the three figures.
The reviewer is correct to point out that the Euler-Maruyama (EM) method is used to integrate stochastic differential equations. NEST is generally capable of handling noise (using the EE method by default and the EM method in the absence of passive decay). However, there is neither noise in the original model nor in our implementation of the saccade generator and hence the EM method reduces to the forward Euler method. The revised version of the manuscript now states that tonic neurons are integrated using the forward Euler method (rather than the EM method).
The most important implication of the discrepancy originating from the input description is that there are no issues with the model itself. Once the correct input is provided (the one matching the shape displayed in figure 10 of the original publication), the model produces the expected output. Furthermore, the fact that the discrepancy remains when the input is treated analytically implies that the deviation is not due to our implementation. In the revised version of the manuscript we have improved the corresponding section of the text accordingly.
F is a constant but we agree that the equations in the original version of the manuscript suggest that F is a function of time. In the revised version of the manuscript we have changed F(t) to simply read F. Text
Thank you for pointing out this omission. The revised manuscript now explains the subscripts. Furthermore, all typos found by the reviewer have been corrected and the manuscript has been thoroughly re-read to check for further typos.
For the revised version of the manuscript we have rechecked all equations.
The original version of the manuscript uses \frac{d}{dt} to indicate temporal derivatives in line with the style of the work we refer to, the revised manuscript uses \dot{\boxempty} to reduce visual clutter. Figures
We have adjusted the figures accordingly.
Thank you for the advice, we have done that.
Sorry. These values are arbitrary and have been removed from the figure
This is a misunderstanding, the respective sentence in the original version of the manuscript is not specifying the panels but just stating an observation. In the revised version we have improved the description of the panels and moved the respective sentence to the main text.
The reviewer is right that this is not obvious in the original version of the manuscript. The line styles differentiate between low and high velocity saccades. The revised manuscript makes this explicit. Code
We have added further comments.
The newly added comments explain this better.
Thank you for pointing this out. We have added this information.
The scripts now comply with PEP8.
Both reviewers are correct to point out that the code runs with Python 3. This is now explicitly mentioned in the manuscript. In compliance with the second reviewer, we have opted for using
We corrected this typo. Reviewer 2
The code indeed runs with Python 3. This is now explicitly mentioned in the manuscript. Thank you for pointing out the option to use |
|
@otizonaizit @gdetor @apdavison Gentle reminder... |
|
@gdetor @apdavison : my impression is that the authors have addressed all your points in great detail, so I think I just need a confirmation from you that I can accept the submission as is :) |
|
@otizonaizit I was planning to re-run the scripts just to double check there have been no regressions, but otherwise I'm happy for you to accept the submission. |
|
@otizonaizit The authors addressed properly all the issues. All the scripts run now smoothly and out-of-the-box. I suggest to you to accept the submission. |
|
@gdetor thanks for endorsing the article. We corrected the typos you mention. |
|
@otizonaizit Any update? |
|
Article is published with |
AUTHOR
Mario Senden; Jannis Schuecker; Jan Hahne; Markus Diesmann; Rainer Goebel
Dear @ReScience/editors,
I request a review for the following replication:
Original article
Title: A Neural Model of the Saccade Generator in the Reticular Formation.
Author(s): Gancarz, G. & Grossberg, S
Journal (or Conference): Neural Networks
Year: 1998
DOI: 10.1016/S0893-6080(98)00096-3
PDF: Gancarz-1998.pdf
Replication
Author(s): Senden, M., Schuecker, J., Hahne, J., Diesmann, M. and Goebel, R.
Repository: Senden-2018
PDF: Senden-2018
Keywords: saccade generation; rate neurons; reticular formation
Language: Python; NEST
Domain: Neuroscience
Results
Potential reviewers
EDITOR
13 February 201813 February 201816 February 201823 April 201823 April 20184 May 2018