-
Notifications
You must be signed in to change notification settings - Fork 97
Review Request: T. Poisot #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@karthik Can you edit this submission ? |
|
@rougier Yes, I'm happy to edit this. |
|
👋 I've contacted both reviewers. Will update thread when I have a response and when the reviews begin. |
|
Looking forward to reviewing this submission! |
|
@karthik Any progress on 2nd reviewer ? |
|
@rougier Just sent a second reminder yesterday. Will start lining up others |
|
This is a very nice and compact replication of the original article by Wilson and Yoshimura. The paper is clear, concise, and well written. The accompanying code is clear and well annotated. Most of the results from the original work are fully replicated (@tpoisot chose not to reproduce specific stochastic model runs presented by the original authors, which is fine as far as I'm concerned). I only have some relatively minor suggestions, none of which are critical to the substance of the reproduction. Otherwise this is an accept pending minor revisions from my side.
|
|
I have modified the text to answer @ElOceanografo comments. I have been unable to build the PDF on my laptop, but I can give it a try when I regain access to my desktop. |
|
Sorry for the delay. Any progress with the manuscript build, do you need some help? |
|
@rougier Still waiting to hear from Tim. |
|
🎉 finally managed to update the PDF |
|
@karthik @pboesu @dmcglinn @ElOceanografo Can we make a decision about this submission? |
|
Apologies for not being more explicit about this following my initial review. @tpoisot addressed all my comments in 4989845 / #39 (comment) so I am more than happy to recommend acceptance. |
|
I am also happy with the changes and recommend acceptance. |
|
@karthik ping! |
|
@khinsen Could you handle the end of the edition process. The paper has been accepted by both reviewers and only need the publication. If not, I could do it but I've another one to do. |
|
Sorry, I cannot do it before July 26, when I will be back from vacation. |
|
Apologies again @rougier Back in town now and happy to proceed with acceptance. |
|
@tpoisot I'm happy to finally accept your paper after all these delays. There are several steps (mostly at my end) to complete this. First, can you please provide some keywords for publication? |
|
Sure! Do you want more than the ones in the first message (community ecology, specialist, generalist, coexistence, discrete time model) ? |
|
Just a gentle reminder for @karthik. |
|
Hi @tpoisot No worries, the ones you have are sufficient. Bear with me as I work through the remaining steps. |
|
@rougier Can you please give me access to Rescience Archives? |
|
@karthik Done (I've invited you) |
|
Hi @tpoisot Once you ok this PR (ReScience-Archives/Poisot-2018#1) I will be able to proceed with next steps. 🙏 |
|
@tpoisot Thank you! Here is the article pdf with all the metadata. I'm about to archive in Zenodo and post to the journal shortly. |
|
Congrats @tpoisot! Your paper has been published. |
AUTHOR
Dear @ReScience/editors,
I request a review for the following replication:
Original article
Title: On the coexistence of specialists and generalists
Author(s): David Sloan Wilson and Jin Yoshimura
Journal (or Conference): The American Naturalist
Year: 1994
DOI: 10.1086/285702
PDF: http://www.journals.uchicago.edu/doi/abs/10.1086/285702
Replication
Author(s): Timothée Poisot
Repository: https://github.com/PoisotLab/ReScience-submission
PDF: https://github.com/PoisotLab/ReScience-submission/blob/poisot-2017/article/Poisot-2017.pdf
Keywords: community ecology, specialist, generalist, coexistence, discrete time model
Language: Julia v0.6
Domain: Ecology
Results
Potential reviewers
EDITOR