Simplify Select component by removing dropdown toggle behavior#99
Merged
LittleLittleCloud merged 2 commits intou/xiaoyun/improveSelectfrom Nov 6, 2025
Merged
Simplify Select component by removing dropdown toggle behavior#99LittleLittleCloud merged 2 commits intou/xiaoyun/improveSelectfrom
LittleLittleCloud merged 2 commits intou/xiaoyun/improveSelectfrom
Conversation
Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor select component to remove dropdown behavior
Simplify Select component by removing dropdown toggle behavior
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Select component had dropdown toggle functionality with
_isOpenstate management, but the refactoring intent was to always display all options as a simple list selector.Changes
_isOpenfield,ToggleDropdownAsync(),EnsureOpen(), andIsToggleKey()methodsTryMoveSelection()andTryTypeAhead()no longer return "opened" state since options are always visible@onclickhandler from container divThe component now behaves as a permanently visible list where arrow keys navigate, Enter selects, and Escape cancels.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.