Use interface instead of implementation in UseRazorConsole extension method.#45
Merged
LittleLittleCloud merged 6 commits intoRazorConsole:mainfrom Oct 22, 2025
Merged
Conversation
- Change HostApplicationBuilder to IHostApplicationBuilder for more flexibility - Separate CreateApplicationBuilder from UseRazorConsole for cleaner code style - Update tests to follow non-fluent pattern
Use IHostApplicationBuilder interface and improve code style
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UseRazorConsole extension method to accept IHostApplicationBuilder instead of the concrete HostApplicationBuilder type, enabling support for alternative implementations like WebApplicationBuilder. The change improves flexibility by following the dependency inversion principle.
Key changes:
- Modified the extension method signature to use the interface type
- Updated XML documentation to reflect the interface usage
- Refactored test code to avoid fluent chaining issues caused by interface return types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/RazorConsole.Core/AppHost.cs | Changed method parameter and return type from HostApplicationBuilder to IHostApplicationBuilder with updated documentation |
| src/RazorConsole.Tests/ConsoleAppTests.cs | Split fluent method chain into separate statements to work around type inference limitations with interface returns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
This PR makes the following changes:
This references #41 by moving the extension method to work with the interface instead of the concrete implementation, allowing users to use other implementations such as WebApplicationBuilder.
Changes: