fix(website, core):Fix race condition in web preview rendering.#291
Merged
TeseySTD merged 2 commits intoRazorConsole:mainfrom Jan 29, 2026
Merged
fix(website, core):Fix race condition in web preview rendering.#291TeseySTD merged 2 commits intoRazorConsole:mainfrom
TeseySTD merged 2 commits intoRazorConsole:mainfrom
Conversation
🚀 Preview DeploymentA preview build has been generated for this PR from CI run #21436818516! Download the artifact: To view the preview locally:
🌐 Live Preview URL: https://57e3f42a.razorconsole.pages.dev The live preview will be automatically updated when you push new |
LittleLittleCloud
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #290
This PR fixes an issue where state changes (such as button clicks) were not immediately reflected in the website preview console, requiring a second interaction to update the display.
Problem:
The
RazorConsoleRendererwas subscribing directly to theConsoleRenderer. This caused a race condition where the renderer attempted to read the output buffer (StringWriter) before theConsoleLiveDisplayContextandLiveDisplayCanvashad finished writing the new frame to it.Solution:
LiveDisplayCanvasto expose aRefreshedevent that fires immediately after renderable is written to the console.RazorConsoleRendererto subscribe to_canvas.Refreshedinstead of the rawConsoleRenderersnapshot. This ensures the buffer is captured only after the underlying ANSI output has been fully written.RazorConsoleRendererto correctly capture the initial component render.Changes:
LiveDisplayCanvas.cs: AddedRefreshedevent invocation inUpdateTargetandRefresh.RazorConsoleRenderer.cs: RemovedIObserverimplementation and switched to event-based flushing viaLiveDisplayCanvas.