Select Supports Generic Option Type by claybrooks · Pull Request #281 · RazorConsole/RazorConsole

claybrooks · 2026-01-14T04:14:54Z

Added generic type param to Select.

Added the following Parameters

TItem: Specifies the Type of options
Formatter: Optional formatter for the display, object.ToString() called by default
Comparer: Optional comparer for options, object.Equals() called by default.
- For strings, this equates to str1.Equals(str2, Ordinal), so previous functionality is preserved

Considerations

It's very likely existing <Select/> code will break due to not being able to infer type of TItem, especially in the ValueChanged parameter.
- I thought I could fix this with public class Select : Select<string>{} but razor doesn't like that. Seems like there is no way around a breaking change
I initially implemented a cache for all of the formatted options, but managing the cache was difficult especially when dealing with modified option objects outside the scope of the Select. So for now, each render pass calls Format(). I can revisit this if it's something you'd prefer

…n flow through

…brooks/RazorConsole into u/claybrooks/complex-select

github-actions · 2026-01-14T04:19:38Z

🚀 Preview Deployment

A preview build has been generated for this PR from CI run #21182647521!

Download the artifact:
website-preview-281-0a09f90acf29645309fb933aa7f3f18c47d0bca6

To view the preview locally:

Download the artifact from the CI workflow run
Extract the ZIP file
Serve the files with a local web server
(e.g., npx serve dist)

🌐 Live Preview URL: https://c07a232c.razorconsole.pages.dev

The live preview will be automatically updated when you push new
commits to this PR.

LittleLittleCloud · 2026-01-14T21:13:07Z

src/RazorConsole.Gallery/Pages/SelectGallery.razor

+    private string? FocusedOption = null;
+    private bool IsFocused;
+    private static readonly string _exampleCode = @"<Rows>
+        <Select TItem=""string"" Options=""@(new[] { ""Align"", ""Border"", ""Columns"", ""Panel"", ""Select"", ""Text Input"" })""


Is it necessary to pass TItem here? The code above that actually render the component doesn't expliclty pass the TItem parameter.

No, in this case it is not necessary. I've removed it. It seems like the only time you need to specify TItem is when you have an explicit ValueChanged binding. For whatever reason, the compiler can't deduce TITem. But if you use @bind-Value, it's fine.

src/RazorConsole.Website/Components/Select_1.razor

Copilot

Pull request overview

This PR makes the Select component generic (Select<TItem>) so it can operate on arbitrary item types, with support for custom display formatting and equality comparison, and updates call sites/tests accordingly.

Changes:

Generalized Select to Select<TItem> with new Formatter and Comparer parameters and internal helpers to use these for rendering, selection, and type-ahead behavior.
Updated tests and sample usage (gallery and website) to construct Select<string> explicitly or rely on inference, and added a NavBar example that binds Select<Tab> with a custom formatter.
Performed minor layout/copy improvements in the select gallery page (panel title, indentation).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`src/RazorConsole.Core/Components/Select.razor`	Core change: converts `Select` to `Select<TItem>`, wires in `Comparer`/`Formatter`, and updates selection, focus, and type-ahead logic to work with generic items instead of hard-coded `string`.
`src/RazorConsole.Gallery/Components/NavBar.razor`	Switches NavBar to use `Select<Tab>` with a `Formatter` projecting labels, demonstrating generic `Select` with a complex item type.
`src/RazorConsole.Gallery/Pages/SelectGallery.razor`	Keeps the gallery example using string options and updates panel labeling/formatting to clarify it’s the string-based select example.
`src/RazorConsole.Tests/Components/SelectTests.cs`	Adjusts the test hosts to construct `Select<string>` explicitly so existing behavior tests still compile against the generic component.
`src/RazorConsole.Website/Components/Select_1.razor`	Updates the website sample to declare `TItem="string"` for the basic select demo so it binds correctly to the new generic component.

src/RazorConsole.Core/Components/Select.razor

Copilot · 2026-01-18T06:49:09Z

src/RazorConsole.Gallery/Pages/SelectGallery.razor

-        private string? FocusedOption = null;
-        private bool IsFocused;
-        private static readonly string _exampleCode = @"<Rows>
+    private string Select = "Align";


Field 'Select' can be 'readonly'.

Copilot · 2026-01-18T06:49:10Z

src/RazorConsole.Gallery/Pages/SelectGallery.razor

-        private bool IsFocused;
-        private static readonly string _exampleCode = @"<Rows>
+    private string Select = "Align";
+    private string? FocusedOption = null;


Field 'FocusedOption' can be 'readonly'.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xiaoyun Zhang <bigmiao.zhang@gmail.com>

src/RazorConsole.Core/Components/Select.razor

src/RazorConsole.Gallery/Components/NavBar.razor

claybrooks and others added 6 commits December 31, 2025 14:28

Removed TargetFrameworks so Directory.Build.props TargetFrameworks ca…

b374993

…n flow through

Initial pass at complex type select component

07ad830

Merge branch 'RazorConsole:main' into u/claybrooks/complex-select

374f89d

Removed format caching

2bcb0de

Merge branch 'u/claybrooks/complex-select' of https://github.com/clay…

0dc0fd0

…brooks/RazorConsole into u/claybrooks/complex-select

Fixed selecting tab on start

8bb6fec

TeseySTD previously approved these changes Jan 14, 2026

View reviewed changes

TeseySTD requested a review from LittleLittleCloud January 14, 2026 20:57

LittleLittleCloud reviewed Jan 14, 2026

View reviewed changes

removed unecessary TItem

18cca97

claybrooks dismissed TeseySTD’s stale review via 18cca97 January 14, 2026 22:41

LittleLittleCloud reviewed Jan 15, 2026

View reviewed changes

src/RazorConsole.Website/Components/Select_1.razor Show resolved Hide resolved

LittleLittleCloud requested a review from Copilot January 18, 2026 06:45

Copilot started reviewing on behalf of LittleLittleCloud January 18, 2026 06:46 View session

LittleLittleCloud previously approved these changes Jan 18, 2026

View reviewed changes

Copilot AI reviewed Jan 18, 2026

View reviewed changes

Apply suggestions from code review

0a09f90

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xiaoyun Zhang <bigmiao.zhang@gmail.com>

LittleLittleCloud dismissed their stale review via 0a09f90 January 20, 2026 18:20

LittleLittleCloud enabled auto-merge (squash) January 20, 2026 18:21

ParadiseFallen reviewed Jan 21, 2026

View reviewed changes

src/RazorConsole.Core/Components/Select.razor Show resolved Hide resolved

src/RazorConsole.Gallery/Components/NavBar.razor Show resolved Hide resolved

LittleLittleCloud merged commit dee3998 into RazorConsole:main Jan 25, 2026
7 checks passed

github-actions bot added this to the v0.3.0 milestone Jan 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Select Supports Generic Option Type#281

Select Supports Generic Option Type#281
LittleLittleCloud merged 8 commits intoRazorConsole:mainfrom
claybrooks:u/claybrooks/complex-select

claybrooks commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

LittleLittleCloud Jan 14, 2026

Uh oh!

claybrooks Jan 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 18, 2026

Uh oh!

Copilot AI Jan 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

claybrooks commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Preview Deployment

Uh oh!

LittleLittleCloud Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

claybrooks Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Jan 14, 2026 •

edited

Loading

claybrooks Jan 14, 2026 •

edited

Loading