Skip to content

Add code style rules#153

Merged
LittleLittleCloud merged 7 commits intomainfrom
u/xiaoyun/formatting
Nov 25, 2025
Merged

Add code style rules#153
LittleLittleCloud merged 7 commits intomainfrom
u/xiaoyun/formatting

Conversation

@LittleLittleCloud
Copy link
Member

No description provided.

This commit adds a copyright notice to the top of all source files in the RazorConsole project, ensuring proper attribution and protection of intellectual property. The notice states that the rights are reserved for RazorConsole.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive code style enforcement rules to the RazorConsole project, including copyright headers, removal of unused imports, and build-time code analysis warnings.

Key changes:

  • Adds copyright headers to all source files across the project
  • Removes unused using directives from all files
  • Configures .editorconfig with new diagnostic rules (IDE0005, IDE0073, IDE0044, IDE0055)
  • Enables code analysis enforcement in build via Directory.Build.props

Reviewed Changes

Copilot reviewed 101 out of 101 changed files in this pull request and generated 9 comments.

File Description
.editorconfig Adds file header template, unused using detection, readonly modifier enforcement, and formatting rules
Directory.Build.props Enables code analyzers and enforces code style in build with EnforceCodeStyleInBuild and CodeAnalysisTreatWarningsAsErrors
RazorConsole.Tests.csproj Enables XML documentation generation for test project
All .cs files Adds copyright headers and removes unused imports

ParadiseFallen
ParadiseFallen previously approved these changes Nov 22, 2025
Copy link
Collaborator

@ParadiseFallen ParadiseFallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whould like to see indent_style = space. Everything else is fine

@ParadiseFallen
Copy link
Collaborator

@copilot add ident_style = space. Then make a review of .editorconfig

Copy link
Contributor

Copilot AI commented Nov 23, 2025

@ParadiseFallen I've opened a new pull request, #182, to work on those changes. Once the pull request is ready, I'll request review from you.

@ParadiseFallen
Copy link
Collaborator

Oh, didn't notice that it's already added

Signed-off-by: ParadiseFallen <50731756+ParadiseFallen@users.noreply.github.com>
@LittleLittleCloud LittleLittleCloud enabled auto-merge (squash) November 25, 2025 05:33
@LittleLittleCloud
Copy link
Member Author

@ParadiseFallen should be good to go now

@LittleLittleCloud LittleLittleCloud merged commit 84fb574 into main Nov 25, 2025
5 checks passed
@LittleLittleCloud LittleLittleCloud deleted the u/xiaoyun/formatting branch November 25, 2025 16:18
@github-actions github-actions bot added this to the v0.2.0 milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants