feat: Add support for acting on workspace comments and icons.#625
feat: Add support for acting on workspace comments and icons.#625
Conversation
BenHenning
left a comment
There was a problem hiding this comment.
Generally looks good, though is it possible to add tests for both comment cases?
Co-authored-by: Ben Henning <bhenning@google.com>
|
This PR fixes #614. |
|
Tests have been added. |
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko. LGTM, though happy to take another pass if you'd like. I did have a few suggestions, but I think they're all hopefully non-controversial.
| chai.assert.equal(focusedNodeId, `${this.comment1}_collapse_bar_button`); | ||
| }); | ||
|
|
||
| test('Activate workspace comment button', async function () { |
There was a problem hiding this comment.
Maybe add a test for toggling to show that it can be expanded.
There was a problem hiding this comment.
I think that'd be better handled in the core workspace comment tests; my goal here is just to ensure that the keyboard nav infrastructure is hooked up to the underlying views/buttons.
|
Feedback from @microbit-grace testing workspace comments nav today:
|
|
I've used the following styles in MakeCode on our preview branch which includes this PR. Maybe use the same blue as for /* Comments are yellow default highlight is orange */
--blockly-active-workspace-comment-color: black;... /* Workspace comments */
.blocklyKeyboardNavigation .blocklyComment.blocklyActiveFocus .blocklyCommentHighlight {
stroke: var(--blockly-active-workspace-comment-color);
stroke-width: 4px;
}
.blocklyCommentTopbar .blocklyActiveFocus {
outline: 2px solid var(--blockly-active-workspace-comment-color);
border-radius: 2px;
outline-offset: -1px;
}
Yellow on yellow or the orange outline seem too subtle. |
|
Also noticed that comments are not scrolled into view when you navigate to them. |
|
Thanks for the feedback! Agreed that all broadly sounds reasonable; I'll merge this as-is to unblock #626 and address those points in a followup later today. |
In conjunction with RaspberryPiFoundation/blockly#9182, this PR adds support for editing workspace comments, activating their icons via keyboard navigation, and moving them.