Skip to content

feat: aria utility additions / improvements#9690

Merged
mikeharv merged 2 commits intoRaspberryPiFoundation:v13from
mikeharv:aria-utils
Apr 8, 2026
Merged

feat: aria utility additions / improvements#9690
mikeharv merged 2 commits intoRaspberryPiFoundation:v13from
mikeharv:aria-utils

Conversation

@mikeharv
Copy link
Copy Markdown
Contributor

@mikeharv mikeharv commented Apr 7, 2026

The basics

The details

Resolves

Fixes #9633

Proposed Changes

  • Added new ARIA utility functions: getRole, getState, and clearState.
  • Added missing roles and states from the Blockly design doc to ensure full ARIA coverage.
  • Standardized existing ARIA comments for consistency and clarity.
  • Updated and expanded unit tests:
    • Created a separate Utils suite to test getRole, getState, setState, and clearState.
    • Live region tests remain in the Live Region suite but were organized under the top-level Aria suite for clarity.

Reason for Changes

The aria utils were missing some necessary roles/states. This aligns them to section 4.1.1 in the design doc

Test Coverage

  • Live region behavior remains fully tested, now in its own suite
  • Unit tests added for:
    • getRole behavior for known, unknown, and missing roles.
    • setState storing boolean, string, number, and array values.
    • getState retrieving stored values and returning null when unset.
    • clearState removing attributes correctly.

@mikeharv mikeharv requested a review from a team as a code owner April 7, 2026 21:08
@mikeharv mikeharv requested a review from maribethb April 7, 2026 21:08
@mikeharv mikeharv changed the base branch from main to v13 April 8, 2026 12:58
@maribethb
Copy link
Copy Markdown
Contributor

Please update PR title though

@mikeharv mikeharv changed the title Aria utils feat: aria utility additions / improvements Apr 8, 2026
@github-actions github-actions bot added the PR: feature Adds a feature label Apr 8, 2026
@mikeharv mikeharv enabled auto-merge (squash) April 8, 2026 14:38
@mikeharv mikeharv merged commit b4d21b2 into RaspberryPiFoundation:v13 Apr 8, 2026
6 checks passed
@mikeharv mikeharv deleted the aria-utils branch April 8, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aria utility additions / improvements

2 participants