Skip to content

feat: Dashboard redesign #1750

Merged
billz merged 1 commit intoRaspAP:feat/dashboard-redesignfrom
neo773:bs-redeisgn
Feb 7, 2025
Merged

feat: Dashboard redesign #1750
billz merged 1 commit intoRaspAP:feat/dashboard-redesignfrom
neo773:bs-redeisgn

Conversation

@neo773
Copy link
Copy Markdown
Contributor

@neo773 neo773 commented Feb 6, 2025

This PR redesigns the dashboard from the mockups

P.S I need some help with the dynamic variables to replace hardcoded client count and fetch device status, I'm not really familiar with the inner workings of this project. Maybe you can point to documentation?

Screenshot 2025-02-07 at 3 19 10 AM Screenshot 2025-02-07 at 3 19 34 AM Screenshot 2025-02-07 at 3 19 49 AM

/claim #1749
/closes #1749

@billz
Copy link
Copy Markdown
Member

billz commented Feb 7, 2025

@neo773 nice implementation and done incredibly fast 😅 You've gone above and beyond with the PHP logic, which I was intending to do. Re: dynamic variables for client count and device status, I'll handle this portion so no worries there. The next phase will involve hooking up all the visual elements with their respective statuses and linking the page actions.

You've done exceptional work here. Thank you!

Would you mind squashing the 'wip' commits and changing the base branch for this PR to feat/dashboard-redesign ?

@neo773
Copy link
Copy Markdown
Contributor Author

neo773 commented Feb 7, 2025

@billz
Thank you for the feedback,

As for squashing just pushed it.

@billz
Copy link
Copy Markdown
Member

billz commented Feb 7, 2025

@neo773 perfect, thanks. If you can change the base branch we can wrap up the bounty.

@neo773
Copy link
Copy Markdown
Contributor Author

neo773 commented Feb 7, 2025

@billz
Sorry, I’m not sure what you mean, do you want me to rename the branch?

@billz
Copy link
Copy Markdown
Member

billz commented Feb 7, 2025

There's more work to be done, so rather than merge with master you can change the base branch of the PR to feat/dashboard-redesign.

@neo773 neo773 changed the base branch from master to feat/dashboard-redesign February 7, 2025 09:12
@neo773
Copy link
Copy Markdown
Contributor Author

neo773 commented Feb 7, 2025

done

@billz
Copy link
Copy Markdown
Member

billz commented Feb 7, 2025

perfect, thanks!

@billz billz merged commit 58501a7 into RaspAP:feat/dashboard-redesign Feb 7, 2025
@billz
Copy link
Copy Markdown
Member

billz commented Feb 7, 2025

@neo773 it was a pleasure collaborating with you on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard redesign with Bootstrap v5.3

2 participants