Show cloud sayes sync operation in the status bar#640
Merged
loathingKernel merged 8 commits intoRareDevs:mainfrom Nov 21, 2025
Merged
Show cloud sayes sync operation in the status bar#640loathingKernel merged 8 commits intoRareDevs:mainfrom
loathingKernel merged 8 commits intoRareDevs:mainfrom
Conversation
Contributor
loathingKernel
commented
Nov 20, 2025
- RareLauncher: avoid crash when server has been deleted already
- RareBaseGame: use class logger instead of file logger
- Verify/MoveWorker: move signals class definition out of qrunnable class
- CloudSaves: use class logger
- Verify/MoveWorker: set RareGame's state on worker instatiation
- QueueWorker: add prefix property to the information about the worker
- CloudSyncWorker: add queue worker to sync saves with the cloud
- Rare: update to use CloudSyncWorker
We should not be able to enqueue another worker when a worker is waiting or is operating on a RareGame. To avoid that, set the RareGame's state as soon as the worker is instatiated and refuse to add another worker if one is already atteched to the RareGame.
Uploading or downloading saves takes some time occasionally. Add the operation as a queue worker to be visible in the bottom status bar
Because syncing is a network operation and verify/move are disk IO operation, a second threadpool and queue were added to contain separate them and queue the workers independently. One threadpool handles disk io tasks and the other networking tasks with a maximum of 2 active threads for each of them.
31bf73e to
e94631a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.