Merged
Conversation
Contributor
loathingKernel
commented
Oct 27, 2025
- project: limit Qt versions
- RareLauncher: try to emulate reaper if SteamGameId is in the environment
- GameDetails: Update form
- StoreDetails: update form
- RareCore: replace global logger with class member
- RareException: Use a messagebox with detailed descriptions for the exception
- workflows: upload zsync for appimage
- pyproject: use vdf from https://github.com/solsticegamestudios/vdf
- freeze: exclude libqgtk3.so
- RareStyle: increase scrollbar width/height
- chore: clean-up some code related to the library
- misc: update flatpak requirements
- ImageManager: use rotated tall image if wide image is missing
Demoting it caused severe issues resulting in segmentation faults because RareGame subclass has methods declared as Slots.
There was a problem hiding this comment.
Pull Request Overview
This pull request contains a comprehensive set of maintenance and enhancement changes across multiple components of the Rare launcher application. The primary focus is on code organization improvements, bug fixes, library updates, and UI refinements.
Key changes include:
- Replacement of global loggers with class-based logging throughout the codebase
- Refactoring of RareGame signals and base classes to properly inherit from QObject with proper cleanup
- Renaming of variables and classes for consistency (e.g.,
LaunchArgstoLaunchParams,GameInfoTabstoGameDetailsTabs) - UI updates including layout changes, widget renaming, and style adjustments for scrollbars
- Dependency updates (PySide6 version constraint, VDF library source change)
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| rare/widgets/rare_app.py | Enhanced exception handling with better user messaging and detailed error reporting |
| rare/shared/rare_core.py | Converted global logger to class member and added cleanup for games on deletion |
| rare/shared/image_manager.py | Major refactoring with improved threading, multi-processing support, and image rotation fallback |
| rare/models/signals.py | Made GlobalSignals inherit from QObject with proper cleanup |
| rare/models/game.py | Renamed pixmap methods and improved pixmap availability checking |
| rare/models/base_game.py | Extracted RareGameSignals as separate QObject class with proper lifecycle management |
| rare/models/enumerations.py | Added ANDROID filter for library |
| rare/commands/launcher/* | Renamed Args classes to Params and refactored game launching for Steam compatibility |
| rare/components/tabs/library/* | Renamed GameInfoTabs to GameDetailsTabs and restructured layout |
| rare/components/tabs/store/* | Fixed typo in diesel.py ("desciption" to "description") and improved logging |
| pyproject.toml & requirements | Updated PySide6 version constraint and VDF library source |
| UI files | Updated Qt forms with layout adjustments and widget renaming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
16bb3fe to
91e040c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.