Pull request artifacts

last change: Monday 2025-08-04 05:21:40

Not sure how to fix the errors in the above comment, but they seem to work locally for me:

1. By channel ID: http://localhost:9001/?action=display&bridge=YouTubePostsTabBridge&context=By%20channel%20ID&channel=UCULkRHBdLC5ZcEQBaL0oYHQ&format=Html
2. By username: http://localhost:9001/?action=display&bridge=YouTubePostsTabBridge&context=By%20username&username=YouTubeUK&format=Html

Not sure how to fix the errors in the above comment, but they seem to work locally for me:

That's from this line:

There, the result of extractJson is used. This function just does a preg_match for a certain piece of JSON and parses it. If the JSON-parsing fails, then there should be a different error. So it looks like JSON is successfully parsed. I had a look at it in curl. Looks good. However, there c4TabbedHeaderRenderer doesn't occur in the JSON at all. Hence, this line fails. When I looked at it, there were multiple places containing the title:

• $json->header->pageHeaderRenderer->pageTitle
• $json->metadata->channelMetadataRenderer->title
• $json->microformat->microformatDataRenderer->title

The question is why the said line didn't fail when you tried it. I have two theories:

• YouTube doesn't always output the same JSON. Might be A/B-testing. Might be the guessed device type. Might be based on your location.
• Your PHP version or config doesn't throw an error but just a warning while using NULL.

You could test this by checking whether your feed has a feedTitle.

Maybe the following line could fix it. It uses the null coalescing operator, which doesn't emit a warning but just attempts the next expression if the previous one would have been NULL.

$this->feedName = $json->header->c4TabbedHeaderRenderer->title ?? $json->header->pageHeaderRenderer->pageTitle ?? $json->metadata->channelMetadataRenderer->title ?? $json->microformat->microformatDataRenderer->title ?? '';

With this line, all currently known locations of the title would be checked and the empty string would be the fallback if none worked.

Thanks @Mar-Koeh that seemed to work. The remaining errors are from a file that no longer exists after this PR renamed it.

Can you please not rename the class? The fix itself is nice and will resolves issues for existing feeds

also

FILE: /home/runner/work/rss-bridge/rss-bridge/bridges/YouTubePostsTabBridge.php
-------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------
 76 | ERROR | [x] Expected 1 space before "??"; newline found
 77 | ERROR | [x] Expected 1 space before "??"; newline found
 78 | ERROR | [x] Expected 1 space before "??"; newline found
 79 | ERROR | [x] Expected 1 space before "??"; newline found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

Time: 33.27 secs; Memory: 46.01MB

sorry strict linter rules

@dvikan Do you prefer I also not rename the functions and comments to reflect the new tab name?

goahead and rename everything you want except class name

being on php 7 not 8 and the strict linter made the regression fix a bit ugly, but it works and should be good now