Pull request artifacts

last change: Sunday 2024-12-08 22:00:01

The embedded icon is a teal version of their regular favicon to match their deals icon on X. This icon isn't available anywhere, so I chose to embed it. The embedded icon only shows up in the Atom feed -- I don't see it in the Mrss feed (maybe a bug?).

I've had problems with FreshRSS 1.24.3 generating duplicate items from this feed, particularly when it's changing frequently (Black Friday). The FreshRSS log has entries about invalid GUIDs every time this happens:

[Tue, 03 Dec 2024 09:45:06 -0600] [warning] --- Feed has valid GUIDs again: http://rss-bridge/?action=display&bridge=WirecutterDealsBridge&format=Mrss
[Tue, 03 Dec 2024 10:30:13 -0600] [warning] --- Feed has invalid GUIDs: http://rss-bridge/?action=display&bridge=WirecutterDealsBridge&format=Mrss

I haven't been able to track down this issue so far. My only thought is that rss-bridge is falling back to URL-based GUIDs from sha1-based GUIDs sometimes (?). It might also be fixed by FreshRSS/FreshRSS#4487.

move collectData method to top so class can be read like a book