Skip to content

fix: move debug mode to config#3324

Merged
dvikan merged 8 commits intoRSS-Bridge:masterfrom
dvikan:fix-14
Jun 2, 2023
Merged

fix: move debug mode to config#3324
dvikan merged 8 commits intoRSS-Bridge:masterfrom
dvikan:fix-14

Conversation

@dvikan
Copy link
Contributor

@dvikan dvikan commented Mar 21, 2023

Make it possible to toggle the debug mode with a config change. Preserve old DEBUG file if present.
Not moving the debug whitelisting to config. I suspect it's rarely used. Maybe wrong on that.
My motivation was to prepare separation between debug mode and various cache behavior due to future features.

@dvikan
Copy link
Contributor Author

dvikan commented Mar 22, 2023

Perhaps a better config name is debug_mode or enable_debug_mode.

@em92
Copy link
Contributor

em92 commented Mar 24, 2023

Not moving the debug whitelisting to config. I suspect it's rarely used.

It is used. In my instance for example. curl https://feed.eugenemolotov.ru/DEBUG
Debug whitelisting is very convenient, so it should be saved.

@dvikan
Copy link
Contributor Author

dvikan commented Mar 26, 2023

Add debug_mode_whitelist to config after feedback from @em92

@em92
Copy link
Contributor

em92 commented Mar 30, 2023

Previously debug mode messaged differed, when comparing debug mode for some IP address and debug mode for everyone
https://i.imgur.com/6Gri9S4.png
https://i.imgur.com/BBWEuPZ.png

I sugget to leave same difference between messages. Including background colors.

@dvikan
Copy link
Contributor Author

dvikan commented Apr 12, 2023

@em92 Fixed.

@em92
Copy link
Contributor

em92 commented Apr 13, 2023

Another thing I payed attention - text looks better when using "text-align: center" like incurrent master.
PR: https://imgur.com/C2cheea.png
Current master: https://imgur.com/5hmWQha.png

@dvikan
Copy link
Contributor Author

dvikan commented Apr 13, 2023

Sure. Agreed.

@dvikan dvikan merged commit ee498ea into RSS-Bridge:master Jun 2, 2023
@dvikan dvikan deleted the fix-14 branch June 2, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@em92 em92 em92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvikan @em92